Keyframe Selection: Add multi-threading and improve overall performances #1512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR speeds up the selection of keyframes on two different accounts:
windowSize / 4
, withwindowSize
the size of the sliding window.It relates to alicevision/Meshroom#2161 and should only be merged once #1510 has been integrated into develop.
Features list
Implementation remarks
The parallelization system using chunks that is used in Meshroom cannot be used to speed the keyframe selection up, because only the step of the score computation can be parallelized: once all the scores have been computed, they need to be put back all together sequentially for the keyframes to actually be selected and this process cannot be split.