Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodes] KeyframeSelection: Add minBlockSize param for multi-threading #2161

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

cbentejac
Copy link
Contributor

Description

The minBlockSize parameter allows to set the minimum number of frames that will be processed by a single thread spawned by the Keyframe Selection process.

It prevents spawning threads that will create their own FeedProvider objects to process a single frame.

@cbentejac cbentejac added this to the Meshroom 2023.3.0 milestone Aug 18, 2023
@cbentejac cbentejac self-assigned this Aug 18, 2023
@cbentejac cbentejac force-pushed the dev/improveKeyframeSelectionPerf branch from 6dec0d9 to 13ae7d9 Compare August 18, 2023 16:52
@cbentejac cbentejac marked this pull request as draft August 24, 2023 09:06
@cbentejac cbentejac force-pushed the dev/improveKeyframeSelectionPerf branch 2 times, most recently from aaf6c02 to 2a6bf03 Compare August 24, 2023 19:58
@cbentejac cbentejac marked this pull request as ready for review August 25, 2023 07:31
@cbentejac cbentejac force-pushed the dev/improveKeyframeSelectionPerf branch from 2a6bf03 to 42868e7 Compare August 25, 2023 13:52
@mugulmd mugulmd merged commit 1a55f6d into develop Aug 25, 2023
2 checks passed
@mugulmd mugulmd deleted the dev/improveKeyframeSelectionPerf branch August 25, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants