feat(alloy-genesis): pk support
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
force-pushed
the
evalir/add-genesis-pk-support
branch
from
cf1a1a8 to
01d3522
Compare
DaniPopes
requested changes
Feb 1, 2024
crates/genesis/Cargo.toml
Outdated
| @@ -14,6 +14,8 @@ exclude.workspace = true | |||
| [dependencies] | |||
| alloy-primitives.workspace = true | |||
| alloy-rpc-types.workspace = true | |||
| alloy-signer.workspace = true | |||
| k256.workspace = true | |||
There was a problem hiding this comment.
we should re-export k256 from alloy-signer actually
crates/genesis/src/lib.rs
Outdated
| skip_serializing_if = "Option::is_none", | ||
| with = "secret_key" | ||
| )] | ||
| pub private_key: Option<LocalWallet>, |
mattsse
requested changes
Feb 1, 2024
crates/genesis/src/lib.rs
Outdated
| pub mod secret_key { | ||
| use alloy_primitives::Bytes; | ||
| use alloy_signer::LocalWallet; | ||
| use k256::{ecdsa::SigningKey, SecretKey}; |
There was a problem hiding this comment.
this should not be required here,
the LocalWallet type should have all the necessary functions, if not we should add
There was a problem hiding this comment.
Not a great idea to serialize pk as raw bytes in general
mattsse
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
missing pk support.
Solution
Adds missing private key support to alloy genesis, see foundry-rs/foundry#6970 (review).
PR Checklist