feat(anvil): migrate in-house Genesis to alloy-genesis
#6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
changed the title
anvil): migrate in-house Genesis to alloy-genesisanvil): migrate in-house Genesis to alloy-genesis
Evalir
commented
Feb 1, 2024
mattsse
requested changes
Feb 1, 2024
Evalir
commented
Feb 1, 2024
crates/anvil/src/config.rs
Outdated
Comment on lines
837
to
843
| env.cfg.chain_id = genesis.config.chain_id; | ||
| env.block.timestamp = U256::from(genesis.timestamp); | ||
| if let Some(base_fee) = genesis.base_fee_per_gas { | ||
| env.block.basefee = U256::from(base_fee); | ||
| } | ||
| env.block.number = U256::from(genesis.nonce); | ||
| env.block.coinbase = genesis.coinbase; |
There was a problem hiding this comment.
this applied these fields conditionally before (see genesis.apply())—but they're not conditional on alloy-genesis. Should check for any default values or just apply them like this?
3 tasks
Evalir
commented
Feb 1, 2024
mattsse
requested changes
Feb 1, 2024
|
ci failure unrelated |
mattsse
approved these changes
Feb 1, 2024
RPate97
pushed a commit
to RPate97/foundry
that referenced
this pull request
Feb 3, 2024
…-rs#6970) * wip: migrate to alloy genesis * feat: switch out from in-house genesis to alloy genesis * chore: rem unneeded file * chore: update alloy, use from_bytes * chore: use proper fns on trait * chore: use block number
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were using a duped genesis struct for anvil.
Solution
Switches anvil to use alloy-genesis