Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ruby to 3.3.0 and Alpine to 3.19 #400

Closed
wants to merge 2 commits into from
Closed

Bump Ruby to 3.3.0 and Alpine to 3.19 #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
209c39f
Bump Ruby to 3.3.0
aliuk2012 Dec 27, 2023
8761c41
ruby 3.3 does not inspect an object when an exception is raised
aliuk2012 Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.2
3.3.0
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ruby:3.2.2-alpine3.18@sha256:198e97ccb12cd0297c274d10e504138f412f90bed50c36ebde0a466ab89cf526 AS build
FROM ruby:3.3.0-alpine3.19@sha256:203b3087530e9cb117d8aab9b49bb766253fd8a6606a0d7520a591c7a3d992f7 AS build

WORKDIR /app

Expand Down Expand Up @@ -26,7 +26,7 @@ ENV RAILS_ENV="${RAILS_ENV:-production}" \

COPY --chown=ruby:ruby . .

FROM ruby:3.2.2-alpine3.18@sha256:198e97ccb12cd0297c274d10e504138f412f90bed50c36ebde0a466ab89cf526 AS app
FROM ruby:3.3.0-alpine3.19@sha256:203b3087530e9cb117d8aab9b49bb766253fd8a6606a0d7520a591c7a3d992f7 AS app

ENV RAILS_ENV="${RAILS_ENV:-production}" \
PATH="${PATH}:/home/ruby/.local/bin" \
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
source "https://rubygems.org"
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

ruby "3.2.2"
ruby "3.3.0"

# Bundle edge Rails instead: gem "rails", github: "rails/rails", branch: "main"
gem "rails", "~> 7.0.8"
Expand Down
11 changes: 5 additions & 6 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ GEM
marcel (1.0.2)
method_source (1.0.0)
mini_mime (1.1.5)
mini_portile2 (2.8.5)
minitest (5.20.0)
msgpack (1.7.2)
net-imap (0.3.7)
Expand All @@ -175,11 +176,8 @@ GEM
net-smtp (0.3.3)
net-protocol
nio4r (2.5.9)
nokogiri (1.15.5-arm64-darwin)
racc (~> 1.4)
nokogiri (1.15.5-x86_64-darwin)
racc (~> 1.4)
nokogiri (1.15.5-x86_64-linux)
nokogiri (1.15.5)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
paper_trail (15.1.0)
activerecord (>= 6.1)
Expand Down Expand Up @@ -317,6 +315,7 @@ GEM
PLATFORMS
arm64-darwin-21
arm64-darwin-22
arm64-darwin-23
x86_64-darwin-21
x86_64-darwin-22
x86_64-linux
Expand Down Expand Up @@ -346,7 +345,7 @@ DEPENDENCIES
tzinfo-data

RUBY VERSION
ruby 3.2.2p53
ruby 3.3.0p0

BUNDLED WITH
2.4.10
6 changes: 1 addition & 5 deletions spec/integration/sentry_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,8 @@
expect(filtered_event.to_hash.to_s).not_to include "submission-email@test.example"
end

it "replaces the email address in the exception with a comment" do
expect(filtered_event.to_hash[:exception][:values].first[:value]).to include "[Filtered (client-side)]"
end

it "keeps the rest of the exception message" do
expect(filtered_event.to_hash[:exception][:values].first[:value]).to include "undefined method"
expect(filtered_event.to_hash[:exception][:values].first[:value]).to eq "undefined method `not_a_method' for an instance of Form (NoMethodError)"
end
end

Expand Down