Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ruby to 3.3.0 and Alpine to 3.19 #400

Closed
wants to merge 2 commits into from
Closed

Conversation

aliuk2012
Copy link
Contributor

@aliuk2012 aliuk2012 commented Dec 27, 2023

Related

What problem does this pull request solve?

Created using our forms-deploy update_app_versions script to bump ruby from 3.2.2 to 3.3.0 and alpine 3.18 to 3.19

Trello card:

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

NoMethod error usess a lot of CPU calling inspect on an object that has
raised the error. In ruby 3.3 inspect has been removed and now the exception
will only contain the objects name that had the issue instead of inspecting it.

see
https://github.com/ruby/ruby/blob/v3_3_0/NEWS.md#compatibility-issues

```
Error message for NoMethodError have changed to not use the target object's #inspect for efficiency, and says "instance of ClassName" instead. [Feature #18285]

([1] * 100).nonexisting

```
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@aliuk2012
Copy link
Contributor Author

Closing this until ruby 3.3.1 is released

see alphagov/forms-runner#561 (comment)

@aliuk2012 aliuk2012 closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant