-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Ruby to 3.3.0 and Alpine to 3.19 #29
Conversation
a13d6a7
to
e5aa473
Compare
@aliuk2012 How did you use the |
@lfdebrux yes, I did run the |
@aliuk2012 have you tested this change in dev? |
@lfdebrux were you thinking of another way other than how I tested it above? |
I was wanting to check whether the new Docker image is working. I would try locally, but as I'm having issues with testing forms-runner that I suspect are related to the fact I have an M1 Mac, it would be better to check in dev. |
oh i see , 🤔 I dont think we can build & push a dev image of e2e tests to test it out. This repo does check that docker image can be built as part of CI tests and it passed in this PR. I've got a M1 Mac and when I ran
|
Closing this until ruby 3.3.1 is released |
Related
What problem does this pull request solve?
Created using our
forms-deploy
update_app_versions
script to bump ruby from 3.2.2 to 3.3.0 and alpine 3.18 to 3.19I ran
gds aws forms-deploy-readonly bin/end_to_end.sh dev
and all tests passed.Trello card:
Things to consider when reviewing