Add header #4289
Merged
Add header #4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
reviewed
Oct 16, 2024
andysellick
approved these changes
Oct 17, 2024
This keeps the breadcrumbs in the sub header with the dark background. Otherwise, the breadcrumbs render above the sub header on a white background. On a separate note, due to the current absence of a content item, I've used Hash.new as the content item to prevent the breadcrumb component from erroring. Additionally, due to the current absence of a content item, both sets of breadcrumbs will currently render; this will be resolved once we pass through the content item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds the landing page header. It is dependent on PR #4284 in the components gem being released.
Why
Trello card