-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inverse option for organisation logo #4284
Conversation
I just noticed this PR and thought I'd comment with a possible quick solution for the inverted icons. We might consider using |
a49364e
to
ac60a53
Compare
Thanks for the suggestion @matthillco - I ended up using a variation of this ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, had a few questions, and would need a changelog entry 👍
app/views/govuk_publishing_components/components/docs/organisation_logo.yml
Outdated
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_organisation-logo.scss
Show resolved
Hide resolved
b1e4282
to
e674adb
Compare
Thanks for the review @AshGDS 👍 Have addressed the comments and added a changelog entry - ready for a re-review when you get a mo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What
Adds an inverse option for the organisation logo component.
This is currently WIP and limited to one organisation. Since organisations have different logos, rolling out a universal inverse option would require inverse versions of every logo.
Why
Part of some requirements.
Visual Changes