Move the breadcrumb outside of the main element #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- skip to content link now bypasses the breadcrumb - change made to keep us consistent following the same change to Elements
|
For reference: |
|
Can you confirm that this has no effect on the rendering of the pages, and that the AB tested breadcrumb which is slightly different also looks the same as it does on live. |
|
I've tested every example page listed on https://github.com/alphagov/government-frontend with this change, including several with both the A and B variants (although I didn't notice a difference in the breadcrumb on those). Also tested with the JS appended banners (e.g. email survey banner). All looked ok. |
fofr
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/IsxWIQXQ/21-2-investigate-work-needed-to-have-breadcrumbs-consistent-with-govuk-elements