Move breadcrumb outside the main element #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a site-wrapper container, move the breadcrumb outside the main element.
Rather than make a breaking change to govuk-elements-sass by removing @extend %site-width-container from the #content area, instead - override it in the documentation styles. Not pretty, but I’d prefer not to make a breaking change for a fix to govuk_elements (the app).
|
@tombye can you please confirm this fixes your issue. If so, we'll need to let GOV.UK Publishing know to amend their breadcrumbs too. cc. @NickColley. |
|
Yep, this fixes it and provides a nice description of the changes needed if people follow this approach. 👍 |
|
I've added this to our support board: https://trello.com/c/IsxWIQXQ/105-investigate-work-needed-to-have-breadcrumbs-consistent-with-govuk-elements |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does the pull request solve?
This allows users to skip directly to the page content, avoiding the repetition of the breadcrumb on each page.
The
<main>tag is wrapped with a containing divsite-wrapper, to establish a central column.The breadcrumb is a child of the site-wrapper container.
The
<main>element starts after the breadcrumb.GOV.UK currently has the breadcrumb inside the
<main>element, ideally, the two should be consistent.Fixes #343.
What type of change is it?
Has the documentation been updated?