Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brand colour for Department for Levelling Up, Housing and Communities (DLUHC) #2434

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

brucebolt
Copy link
Member

@brucebolt brucebolt commented Nov 17, 2021

This is a new department, so adding a new brand colour for this organisation.

Zendesk ticket

DLUHC = Department for Levelling Up, Housing and Communities

The colour has a contrast ratio of 14.75, so not adding a websafe colour
for this organisation.
brucebolt added a commit to brucebolt/govuk-frontend that referenced this pull request Nov 17, 2021
brucebolt added a commit to brucebolt/govuk-frontend that referenced this pull request Nov 17, 2021
@brucebolt brucebolt changed the title Replace brand colour for Department for Communities and Local Government (DCLG) with Department for Levelling Up, Housing and Communities (DLUHC) Add brand colour for Department for Levelling Up, Housing and Communities (DLUHC) Nov 17, 2021
brucebolt added a commit to alphagov/govuk_publishing_components that referenced this pull request Nov 17, 2021
DLUHC = Department for Levelling Up, Housing and Communities

The colour has a contrast ratio of 14.75, so not adding a websafe colour
for this organisation.

The same change has been made in [govuk-frontend](alphagov/govuk-frontend#2434),
however we need to also make the change here until the next release of
govuk-frontend.
brucebolt added a commit to alphagov/govuk_publishing_components that referenced this pull request Nov 17, 2021
DLUHC = Department for Levelling Up, Housing and Communities

The colour has a contrast ratio of 14.75, so not adding a websafe colour
for this organisation.

The same change has been made in [govuk-frontend](alphagov/govuk-frontend#2434),
however we need to also make the change here until the next release of
govuk-frontend.
brucebolt added a commit to alphagov/govuk_publishing_components that referenced this pull request Nov 17, 2021
DLUHC = Department for Levelling Up, Housing and Communities

The colour has a contrast ratio of 14.75, so not adding a websafe colour
for this organisation.

The same change has been made in [govuk-frontend](alphagov/govuk-frontend#2434),
however we need to also make the change here until the next release of
govuk-frontend.
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brucebolt
Copy link
Member Author

Thanks @owenatgov. I don't have permissions to merge on this repo, would you be able to do it for me?

@owenatgov
Copy link
Contributor

I don't have permissions either sadly. Have prompted the design system team who'll have a look in a bit.

@vanitabarrett
Copy link
Contributor

Thanks for raising this @brucebolt - looks good to me. This just needs a second review from someone in the Design System team before it can be merged.

@vanitabarrett vanitabarrett requested a review from a team November 17, 2021 13:11
@vanitabarrett vanitabarrett merged commit 3c30a14 into alphagov:main Nov 17, 2021
frankieroberto pushed a commit to x-govuk/govuk-frontend that referenced this pull request Dec 1, 2021
@vanitabarrett vanitabarrett mentioned this pull request Dec 15, 2021
alex-ju added a commit to alphagov/govuk_publishing_components that referenced this pull request Feb 10, 2022
Temporary added in #2454 this is now available via govuk-frontend alphagov/govuk-frontend#2434
alex-ju added a commit to alphagov/govuk_publishing_components that referenced this pull request Feb 14, 2022
Temporary added in #2454 this is now available via govuk-frontend alphagov/govuk-frontend#2434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants