Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organisation colour for Department for Levelling Up, Housing and Communities (DLUHC) #2454

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

brucebolt
Copy link
Member

DLUHC = Department for Levelling Up, Housing and Communities

What

Adds the brand colour for DLUHC.

The colour has a contrast ratio of 14.75, so not adding a websafe colour for this organisation.

Why

The same change has been made in govuk-frontend, however we need to also make the change here until the next release of govuk-frontend.

Zendesk ticket

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2454 November 17, 2021 11:08 Inactive
@brucebolt brucebolt changed the title Add organisation colour for DLUHC Add organisation colour for Department for Levelling Up, Housing and Communities (DLUHC) Nov 17, 2021
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2454 November 17, 2021 11:09 Inactive
DLUHC = Department for Levelling Up, Housing and Communities

The colour has a contrast ratio of 14.75, so not adding a websafe colour
for this organisation.

The same change has been made in [govuk-frontend](alphagov/govuk-frontend#2434),
however we need to also make the change here until the next release of
govuk-frontend.
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2454 November 17, 2021 11:13 Inactive
Copy link
Contributor

@injms injms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be working as expected:
Screenshot 2021-11-17 at 11 24 13

I'll add an issue so we don't forget to remove this when this change is made in GOV.UK Frontend.

Thanks for adding this Bruce!

@brucebolt
Copy link
Member Author

brucebolt commented Nov 17, 2021

I'll add an issue so we don't forget to remove this when this change is made in GOV.UK Frontend.

Brilliant, thank you.

@brucebolt brucebolt merged commit 58906fc into master Nov 17, 2021
@brucebolt brucebolt deleted the add-dluhc branch November 17, 2021 11:33
@injms injms mentioned this pull request Nov 17, 2021
alex-ju added a commit that referenced this pull request Feb 10, 2022
Temporary added in #2454 this is now available via govuk-frontend alphagov/govuk-frontend#2434
alex-ju added a commit that referenced this pull request Feb 14, 2022
Temporary added in #2454 this is now available via govuk-frontend alphagov/govuk-frontend#2434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants