Skip to content
This repository has been archived by the owner on Feb 13, 2018. It is now read-only.

Add artefact kind for manuals #165

Closed
wants to merge 3 commits into from
Closed

Conversation

tommyp
Copy link
Contributor

@tommyp tommyp commented May 6, 2014

This adds the new Manual artefact which alphagov/specialist-publisher#76 depends on.

@bestie
Copy link
Contributor

bestie commented May 6, 2014

I think we should consider adding a couple of methods to ManualEdition as suggested in my comments on alphagov/specialist-publisher#76

include Mongoid::Document
include Mongoid::Timestamps

field :manual_id, type: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is specific to HMRC's tax manuals (I don't see the service manual using this, for instance). We should consider the object hierarchy appropriately.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is to tie the editions for one manual together. It's generated by the specialist-publisher before a new manual is created and then used for each subsequent edition.

We do the same for SpecialistDocumentEdition: https://github.com/alphagov/govuk_content_models/blob/master/app/models/specialist_document_edition.rb#L8

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OIC. Thanks @evilstreak

@bestie
Copy link
Contributor

bestie commented May 8, 2014

Closing due to removal of ManualEdition collection from content models. This collection will live in Specialist Publisher.

We will later add another collection of rendered manuals for use by the Content API.

@bestie bestie closed this May 8, 2014
@bestie bestie deleted the add-artefact-kind-for-manuals branch May 8, 2014 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants