Add manuals #76
Merged
Add manuals #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| def fetch(manual_id) | ||
| edition = ManualEdition.where(manual_id: manual_id).last |
There was a problem hiding this comment.
This relies on a co-incidence that the most recently added ManualEdition is the last one in this array.
As chaining on an order would make this difficult to test how about adding a method to the mogoid object like ManualEdition.most_recent_by_manual_id? Much better to define our API than depend on Mongoid's 289 methods.
Also adding a cucumber test for validation errors working correctly
This avoids the problem of grouping Mongoid documents and pretending it's a relational database
h-lame
pushed a commit
that referenced
this pull request
Apr 13, 2016
Add curated links to mainstream browse pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to unblock numerous agencies, we need to allow editors to create manuals for their content. This is the first step in that.
In this PR we've added:
#indexfor manuals#newand#editpages (with#createand#updateactions) for manualsThis relies on alphagov/govuk_content_models#165 being merged.