Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Github templates for pull requests and issues #403

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

gemmaleigh
Copy link
Contributor

What problem does the pull request solve?

It updates the pull request and issue templates, in an attempt to encourage their usage - and to provide structure to the issues raised and pull requests opened for GOV.UK elements.

What does it do?

  • uses smaller headings
  • removes the checkboxes, as these imply that a choice is a set of things to be completed
  • requests that lines that don't apply are deleted

What type of change is it?

  • New feature (non-breaking change which adds functionality)

Put an x in all the boxes that apply

  • I have read the CONTRIBUTING document.

- use smaller headings
- remove the checkboxes, as these imply that a choice is a set of things to be completed
- suggest that lines that don't apply are deleted
@robinwhittleton
Copy link
Contributor

Much better!

@robinwhittleton robinwhittleton merged commit 7cb321f into master Feb 10, 2017
@gemmaleigh gemmaleigh deleted the update-pr-template branch March 16, 2017 12:41
gemmaleigh added a commit that referenced this pull request Mar 17, 2017
Remove the core-16 mixin being applied to table cells with a class of
numeric. All tables should use 19px - to match the body text size.

Fixes #403 - Tables have inconsistent front sizes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants