Ensure that table cells using tabular-numbers are 19px #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the core-16 mixin being applied to table cells with a class of numeric. All tables should use 19px - to match the body text size. Fixes #403 - Tables have inconsistent front sizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does the pull request solve?
Fixes #403 - Tables have inconsistent front sizes.
Remove the core-16 mixin being applied to table cells with a class of
numeric. All tables should use 19px - to match the body text size.
How has this been tested?
Tested by running the GOV.UK elements app locally, see screenshots, or Heroku app preview.
Screenshots (if appropriate):
Before:
After:
What type of change is it?
Has the documentation been updated?