-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Ruby 2.7 support #54
Conversation
@MuriloDalRi you'll also need to change the https://docs.publishing.service.gov.uk/manual/publishing-a-ruby-gem.html#ruby-version-compatibility |
I'll update all the PRs. |
Great, I've realised a couple of other things you'll need to do too:
|
0dd6e86
to
f25d5af
Compare
Updates the CHANGELOG.md file to include the following changes: Drop support for Ruby 2.7.
@MuriloDalRi I've opened #55 to add the missing rubocop_govuk dependency, hopefully we can merge that and rebase this. |
Thanks! I'll add a comment to the PR description. I think I've made all the changes needed on all PRs now. I'll ask my team for reviews but if you want to have a go, please do! |
Yup I can review the ones publishing own. It's better if they are reviewed by teams that own the gems, rather than the change just done by your team so that teams are empowered owners and not surprised by changes (even if they're not divisive). |
That's a good point. The plan was for us to merge these PRs and then raise version bump PRs for teams to review and merge themselves, but I'm happy to let them take it from here. |
Sure, I'd not worry about doing version bumps. It doesn't seem necessary to release the dropping of Ruby 2.7 unless there are other changes, so I'd imagine it's best that the Ruby version change just goes out with whatever the next release is. |
Ruby 2.7 reaches EOL on 31st March 2023.
#55 should be merged before this.
https://trello.com/c/ynkZlvh8/3119-drop-ruby-27-support-from-gems-3