Add rubocop-govuk linting #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
MuriloDalRi
approved these changes
Mar 24, 2023
This presumably got missed many moons ago. A specific version is added of rubocop-govuk to ensure there is not divergence in linting between developers of the gem.
rubocop -A
We don't expect the Rakefile to be executed outside of a developer environment so we can avoid the exception handling for RSpec. This resolves a linting violation: Lint/SuppressedException
It's unnecessary to have all these comments. This removes the comments (while making some succinct) and applies some of the common RSpec defaults that were commented out.
|
@kevindew sorry I ended up merging my PR before this! Hope it was an easy rebase! |
|
@MuriloDalRi no problem it was fine, only pain point was noticing main was failing I've opened #56 to resolve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed in #54 (comment) that this project doesn't have rubocop-govuk. This PR adds that in, corrects linting violations and simplifies the spec_helper.rb file (which came out a bit weird after the rubocop autocorrect)