Fix failing main build #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main merge for this repo is failing with an error: ``` (eval):19:in `expand_path': no implicit conversion of nil into String (TypeError) from (eval):19:in `block in <main>' from /opt/hostedtoolcache/Ruby/3.0.5/x64/lib/ruby/site_ruby/3.0.0/rubygems/specification.rb:2055:in `initialize' from (eval):5:in `new' from (eval):5:in `<main>' from -e:1:in `eval' from -e:1:in `<main>' ``` This was occurring because of the contextual command of changing directory that fails when the gemspec is eval'd as part of pushing a gem [1]. While the ultimate cause of this is the fragility of an eval command (🤢) the simplest fix is the simplify the command. [1]: https://github.com/alphagov/govuk-infrastructure/blob/bfc9e8b9549161b524b31b749050e5fc48f8d3f4/.github/workflows/publish-rubygem.yml#L61
These files are for developing the gem and needn't be distributed.
Not too sure why rubocop isn't policing these.
MuriloDalRi
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main merge for this repo is failing with an error:
This was occurring because of the contextual command of changing
directory that fails when the gemspec is eval'd as part of pushing a gem
1. While the ultimate cause of this is the fragility of an eval
command (🤢) the simplest fix is the simplify the command.
This also has a couple of small amends to the gemspec.