Add separate page for editing another user's name

[floehopper]

Trello: https://trello.com/c/uZD2I9dj & https://trello.com/c/DjdHEqxG

This splits out the editing of another user's name into a separate page. The latest design calls for the splitting out the editing of a bunch of user fields into separate pages like this. The new "edit user name" page uses the GOV.UK Design System, but the "edit user" page still does not.

In making this change I have fixed a small bug that was originally present in the "edit user" page but had moved to the new "edit user name" page.

In my use of the error_summary component I have also brought the display of validation errors more into line with this Design System guidance.

New "Change" link on "edit user" page

New "edit user name" page

New "edit user name" page with validation error

Planned design for the "edit user" page (not part of this PR)

[chrislo]

This all looks good to me and I think moving a field at a time is a useful way of keeping the changes manageable. I checked out the branch locally and tested the error states and navigation on a couple of browsers and screen widths.

[floehopper]

Thanks, @chrislo! 🙏

[floehopper]

@chrisroos

I just noticed that I missed this test:

signon/test/controllers/users_controller_test.rb

Lines 663 to 668 in 55adcdf

	should "push changes out to apps" do
	another_user = create(:user, name: "Old Name")
	PermissionUpdater.expects(:perform_on).with(another_user).once
	put :update, params: { id: another_user.id, user: { name: "New Name" } }
	end

And hence this behaviour:

signon/app/services/user_update.rb

Lines 127 to 129 in 55adcdf

	def perform_permissions_update
	PermissionUpdater.perform_on(user)
	end

When I inlined UserUpdate into Users:NamesController#update in this PR. I don't really understand why we'd want to send a permission update out to the users apps just because we've changed their name - probably just because this has got lumped into the UserUpdate mess. Anyway, I don't think it's a big deal, but thought I'd highlight it just in case something comes up about it next week.

[chrisroos]

@chrisroos

I just noticed that I missed this test:

signon/test/controllers/users_controller_test.rb

Lines 663 to 668 in 55adcdf

	should "push changes out to apps" do
	another_user = create(:user, name: "Old Name")
	PermissionUpdater.expects(:perform_on).with(another_user).once
	put :update, params: { id: another_user.id, user: { name: "New Name" } }
	end

And hence this behaviour:

signon/app/services/user_update.rb

Lines 127 to 129 in 55adcdf

	def perform_permissions_update
	PermissionUpdater.perform_on(user)
	end

When I inlined UserUpdate into Users:NamesController#update in this PR. I don't really understand why we'd want to send a permission update out to the users apps just because we've changed their name - probably just because this has got lumped into the UserUpdate mess. Anyway, I don't think it's a big deal, but thought I'd highlight it just in case something comes up about it next week.

I've been doing some digging and I think we might want to update the client app when the name changes, in order to retain the previous behaviour.

Prior to this change, when a user's name was updated in Signon it would also be updated in the client app (e.g. Whitehall) very soon after (triggered by the PermissionUpdater). After this change, I think the user's name will only be updated in the client app when they sign in again, or when the user stored in the session expires (default expiry is 20 hours) and the user is authenticated again by gds-sso.

It looks as though gds-sso has supported the updating of name and email, along with permissions, since it was first introduced in 2012. Signon was updated to use this new user update endpoint a few days later, and has also been sending name and email along with permissions, since then.

It feels as though the name of PermissionsUpdater is incorrect and that it should be something more like UserUpdater to indicate that it pushes user updates out to client apps.

I've captured the requirement for updating the name in client apps in this Trello card.