Upgrade jasmine-browser-runner dependencies (particularly "send") #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix a security vulnerability. We had a medium security vulnerability because jasmine-browser-runner depends on express 4.20.0 which depends on serve-static 0.16.0 which depends on send 0.18.0, which is currently vulnerable due to GHSA-m6fv-jmcg-4jfg. We pinned the express dependency to resolve this but now that a new version of serve-static has been released, we can unpin this. The changes to `yarn.lock` were generated by running `yarn upgrade jasmine-browser-runner` to ensure it's using the patched version (0.19.0) of the `send` dependency.
Gweaton
force-pushed
the
fix-send-vulnerability
branch
from
dbf7b52 to
99c656b
Compare
yndajas
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix a security vulnerability.
We had a medium security vulnerability because jasmine-browser-runner depends on express 4.20.0 which depends on serve-static 0.16.0 which depends on send 0.18.0, which is currently vulnerable due to GHSA-m6fv-jmcg-4jfg.
The changes to
yarn.lockwere generated by runningyarn upgrade jasmine-browser-runnerto ensure it's using the patched version (0.19.0) of thesenddependency.This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.