Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bib preview mobile #2359

Merged
merged 4 commits into from
Apr 28, 2024
Merged

Fix bib preview mobile #2359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f73f530
fix(mobile): using single column
CheariX Apr 21, 2024
899841e
fix(style): abbr+preview to 100% widths
CheariX Apr 21, 2024
cfef609
fix(style): year numbers could be covered by text in mobile version
CheariX Apr 21, 2024
83ca901
fix(style): abbr without preview set to 100% widths
CheariX Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions _layouts/bib.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
---
<div class="row">
{% if site.enable_publication_thumbnails %}
<div class="col-sm-2 abbr">
<div class="col col-sm-2 abbr">
{%- if entry.abbr -%}
{%- if site.data.venues[entry.abbr] -%}
{% assign venue_style = null %}
{% if site.data.venues[entry.abbr].color != blank %}
{% assign venue_style = site.data.venues[entry.abbr].color | prepend: 'style="background-color:' | append: '"' %}
{%- endif -%}
<abbr
class="badge rounded"
class="badge rounded w-100"
{% if venue_style %}
{{ venue_style }}
{% endif -%}
Expand All @@ -22,7 +22,7 @@
{% endif %}
</abbr>
{% else %}
<abbr class="badge rounded">{{ entry.abbr }}</abbr>
<abbr class="badge rounded w-100">{{ entry.abbr }}</abbr>
{% endif %}
{% endif %}
{% if entry.preview %}
Expand Down
11 changes: 0 additions & 11 deletions _sass/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,6 @@ table.table a {
}
}

figure,
img {
max-width: 90vw;
}

blockquote {
background: var(--global-bg-color);
border-left: 5px solid var(--global-theme-color);
Expand Down Expand Up @@ -680,7 +675,6 @@ footer.sticky-bottom {
border-top: 1px solid var(--global-divider-color);
padding-top: 1rem;
margin-top: 2rem;
margin-bottom: -2rem;
text-align: right;
}

Expand All @@ -693,20 +687,15 @@ footer.sticky-bottom {
margin-bottom: 1rem;

.preview {
width: 100%;
min-width: 80px;
max-width: 200px;
}

.abbr {
height: 2rem;
margin-bottom: 0.5rem;

abbr {
display: inline-block;
background-color: var(--global-theme-color);
margin-bottom: 0.5rem;
width: 100%;

a {
color: white;
Expand Down