Experimental hand tracking gestures #1715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
requested changes
Jul 4, 2023
| @@ -265,7 +267,89 @@ pub fn to_openvr_hand_skeleton( | |||
| * Quat::from_euler(EulerRot::YXZ, -FRAC_PI_2, FRAC_PI_2, 0.0), | |||
| position: gj[1].position, | |||
| }; | |||
|
|
|||
| // test pinch | |||
There was a problem hiding this comment.
I believe this is not the right function where to do this. to_openvr_hand_skeleton was supposed to be a "pure" function, ie no side effects. You can create another function with the only purpose of detecting and sending pinches.
Meister1593
force-pushed
the
pinch-gestures
branch
from
37d615d to
3d69e47
Compare
|
Hand tracking gestures support has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for pinch, grab gestures to use them in-game via controller emulation