-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hand tracking gestures #1794
Hand tracking gestures #1794
Conversation
I'd like to mention I'm happy for others to commit changes if they want, and for any criticism/feedback on the currently implemented gestures or suggestions for better alternatives. |
From my experience, a few things can be fine tuned (and probably needs more setting slots). The most frustrating thing is the trigger distance is not that reliable. As #256 (comment) mentioned, the accuracy of Oculus hand pinching only works well on thumb + index, and thumb + pinky is the worst one (and may even be treated as thumb + ring). So you probably need to set trigger distance by each finger, an example from myself can be used as a reference, but since everyone's experience may vary, you can try to find better values. Besides, there're still some tough works to do, though they aren't must-have, just some suggestions from myself.
Anyway, thanks for your hard working, as it shows a working POC. Hope to see it in release! |
I'd prefer a hysteresis-based threshold. I already told @Meister1593 about this and his PR was blocked on him implementing this. |
by this do you mean having a closer activation range than deactivation range, or something else? |
It's having activation range and then deactivation range after it was activated, instead of just being triggered. |
@barnabwhy Can you rebase this PR on master? It seems you pulled in one of my commits and the change list got dirty. |
e2d4d51
to
a103cdf
Compare
a5b0040
to
15bce7b
Compare
cb956d2
to
2f64ac1
Compare
is there a way to do a/b x/y clicks while holding something? i couldn't make it it but would be nice to have if possible |
Tbh I'm not entirely sure how to make it work. In theory you can just touch your thumb to the tip of the relevant finger while gripping but it's definitely a hard tradeoff between a natural grip gesture and ease of using multiple simultaneous inputs |
35bb13b
to
1edab0c
Compare
Some feedback in general on p4 (pro, 5.7.2 global) |
Currently in the process of making the joystick range configurable. Also The joystick click should be done by curling the thumb to the palm if that helps activate it more reliably? It is however quite true it's hard to control the joystick accurately, maybe I should increase the default deadzone? |
is_gesture_active
f621f94
to
de0704a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! One last small thing
Ok that's good enough. Thanks! |
Hi, thank you for the work. |
Support for pinch and curl gestures as well as emulating the joystick. Somewhat based on #1715 originally but changed down the line.
Some of the vector math for calculating the joysticks values and positions is a bit iffy at the moment, I'm not really sure how to improve it and could do with some help there i reckon.I fixed it :3To-do list: