Adds the simpleEnum class back. #246
Conversation
* Adds its meta class back without using six. * Adds unit tests back * Adds a deprecation warning for the class.
amazon/ion/util.py
Outdated
| warn(f'{self.__class__.__name__} was deprecated in favor of the deprecation of `amazon.ion.Enum`. However, for ' | ||
| f'compatibility reasons, `amazon.ion.Enum` has been placed here. We recommend considering using `IntEnum` ' | ||
| f'as an alternative.', | ||
| DeprecationWarning, stacklevel=2) |
There was a problem hiding this comment.
I recommend some stronger language both here and in the other warning.
| warn(f'{self.__class__.__name__} was deprecated in favor of the deprecation of `amazon.ion.Enum`. However, for ' | |
| f'compatibility reasons, `amazon.ion.Enum` has been placed here. We recommend considering using `IntEnum` ' | |
| f'as an alternative.', | |
| DeprecationWarning, stacklevel=2) | |
| warn(f'{self.__class__.__name__} is an internal-only class in ion-python; do not use it for any reason. ' | |
| f'This class is deprecated and may be removed without further warning in any future release. ' | |
| f'Use `IntEnum` instead.', | |
| DeprecationWarning, stacklevel=2) |
There was a problem hiding this comment.
Agree, changed - 3a4708e
amazon/ion/util.py
Outdated
|
|
||
|
|
||
| class Enum(int, metaclass=_EnumMetaClass): | ||
| """Simple integer based enumeration type. |
There was a problem hiding this comment.
| """Simple integer based enumeration type. | |
| """This is a deprecated, internal-only class in ion-python—do NOT use it for any reason. | |
| Simple integer based enumeration type. |
amazon/ion/util.py
Outdated
|
|
||
|
|
||
| class _EnumMetaClass(type): | ||
| """Metaclass for simple enumerations. |
There was a problem hiding this comment.
Let's make it obvious in the doc string too.
| """Metaclass for simple enumerations. | |
| """This is a deprecated, internal-only class in ion-python—do NOT use it for any reason. | |
| Metaclass for simple enumerations. |
|
Found the root why CI/CD fails, see #249. We will skip these 10 failed unit tests for now. This PR passed all tests except these 10 known tests, which is good. |
|
Looks like the build is failing in the Python 3.10 workflow because of an error while trying to load the c extension. Do you know why that might be? |
|
The CI/CD will fail for all python 3.x versions due to the recent ion-c release. Looks like it's because of this commit. Further investigation is required to identify the root cause. Reference issue - #249 for details. So we can either
|
ion-c
Outdated
There was a problem hiding this comment.
Let's revert the submodule update and address that in a separate PR, since it introduced errors that haven't yet been diagnosed.
|
The CI/CD passed due to the mitigation we had #250, which the commit will be reverted once the root cause is fixed. |
Description of changes:
Issue #, if available:
#241
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.