-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the simpleEnum class back. #246
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule ion-c
updated
15 files
+3 −3 | .github/workflows/ion-test-driver.yml | |
+1 −1 | .gitmodules | |
+1 −1 | CMakeLists.txt | |
+3 −3 | CONTRIBUTING.md | |
+4 −4 | README.md | |
+43 −40 | ionc/ion_stream.c | |
+15 −11 | ionc/ion_writer_text.c | |
+3 −3 | test/gather_vectors.cpp | |
+3 −3 | test/test_ion_binary.cpp | |
+105 −1 | test/test_ion_stream.cpp | |
+3 −3 | test/test_ion_text.cpp | |
+1 −1 | test/test_ion_timestamp.cpp | |
+2 −0 | tools/cli/cli.cpp | |
+1 −0 | tools/cli/cli.h | |
+1 −0 | tools/events/ion_event_util.cpp |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
# Copyright 2016 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). | ||
# You may not use this file except in compliance with the License. | ||
# A copy of the License is located at: | ||
# | ||
# http://aws.amazon.com/apache2.0/ | ||
# | ||
# or in the "license" file accompanying this file. This file is | ||
# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS | ||
# OF ANY KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations under the | ||
# License. | ||
|
||
import pytest | ||
|
||
from amazon.ion.util import Enum | ||
|
||
|
||
class SimpleEnum(Enum): | ||
A = 1 | ||
B = 2 | ||
|
||
|
||
def test_enum_members(): | ||
assert SimpleEnum._enum_members == {1: SimpleEnum.A, 2: SimpleEnum.B} | ||
|
||
|
||
def test_enum_reverse_lookup(): | ||
assert SimpleEnum[1] == SimpleEnum.A | ||
assert SimpleEnum[2] == SimpleEnum.B | ||
|
||
|
||
def test_enum_fields(): | ||
assert SimpleEnum.A.value == 1 | ||
assert SimpleEnum.A.name == 'A' | ||
assert SimpleEnum.B.value == 2 | ||
assert SimpleEnum.B.name == 'B' | ||
|
||
values = list(SimpleEnum) | ||
values.sort() | ||
assert values == [SimpleEnum.A, SimpleEnum.B] | ||
|
||
|
||
def test_enum_as_int(): | ||
assert isinstance(SimpleEnum.A, int) | ||
assert SimpleEnum.A == 1 | ||
assert SimpleEnum.A is not 1 | ||
|
||
|
||
def test_malformed_enum(): | ||
with pytest.raises(TypeError): | ||
class BadEnum(Enum): | ||
A = 'Allo' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert the submodule update and address that in a separate PR, since it introduced errors that haven't yet been diagnosed.