This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
feat(metrics): switch to fastify-metrics #1034
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 687 kB ℹ️ View Unchanged
|
Matthew-Mallimo
approved these changes
Jun 23, 2023
dogpatch626
reviewed
Jun 26, 2023
@@ -68,6 +68,11 @@ export async function createApp(opts = {}) { | |||
fastify.register(ensureCorrelationId); | |||
fastify.register(fastifyCookie); | |||
fastify.register(logging); | |||
fastify.register(fastifyMetrics, { | |||
defaultMetrics: { enabled: false }, | |||
endpoint: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we set endpoint to null? how exactly does this change how some one will retrieve the metrics itself? im assuming none but still wondering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is already a separate metrics server running. this disables the plugin from adding metrics routes to the main one app server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha makes sense
dogpatch626
approved these changes
Jun 26, 2023
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts the custom request route metric and replaces with fastify-metrics
This includes metrics for the following, grouped by registered route and status code:
http_request_duration_seconds_count
method
,route
,status_code
http_request_duration_seconds_bucket
method
,route
,status_code
http_request_summary_seconds
method
,route
,status_code
http_request_summary_seconds_count
method
,route
,status_code
Example:
Motivation and Context
Improved http request metrics.
How Has This Been Tested?
Test suite and locally.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?