This repository has been archived by the owner on May 3, 2024. It is now read-only.
chore: consolidate eslint configs #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -33 B (0%) Total Size: 735 kB
ℹ️ View Unchanged
|
10xLaCroixDrinker
force-pushed
the
chore/eslint-consolidation
branch
from
d4ed3f5
to
53f6793
Compare
| @@ -1925,7 +1925,7 @@ describe('Tests that can run against either local Docker setup or remote One App | |||
| ); | |||
| const body = await response.text(); | |||
| expect(body).toBe( | |||
| '<style class="ssr-css">.frank-lloyd-root__styles__stylish___2aiGw{color:orchid}</style><pre class="value-provided-from-config">https://intranet-origin-dev.example.com/some-api/v1</pre><span class="message">Hello!</span>' | |||
| '<style id="90ac7139df6563d22a4a856f04cacf522587d2ec6e66ddb89d06ff844b5bee7c" data-ssr="true">._stylish_1wkbg_1{color:orchid}</style><pre class="value-provided-from-config">https://intranet-origin-dev.example.com/some-api/v1</pre><span class="message">Hello!</span>' | |||
There was a problem hiding this comment.
This is related to updating the bundler in sample modules
10xLaCroixDrinker
force-pushed
the
chore/eslint-consolidation
branch
from
53f6793
to
35f1b11
Compare
dogpatch626
previously approved these changes
Apr 2, 2024
- @americanexpress/one-app-server-bundler@1.1.0 - @fastify/compress@7.0.3 - @fastify/static@7.0.2 - prom-client@15.1.1 - @babel/cli@7.24.1 - @babel/core@7.24.3 - @commitlint/cli@19.2.1 - pino-pretty@11.0.0 - rollup@4.13.2 - tar@6.2.1
dogpatch626
approved these changes
Apr 2, 2024
Matthew-Mallimo
approved these changes
Apr 3, 2024
Merged
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ESLint cleanup/consolidation
Additional dependency updates:
Motivation and Context
Saw we had a few warnings in main for console.logs in markdown files due misconfiguration.
How Has This Been Tested?
npm run test:lint
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
N/A