This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
chore: consolidate eslint configs #1364
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
35f1b11
chore: consolidate eslint configs
10xLaCroixDrinker ab066b6
Merge branch 'main' into chore/eslint-consolidation
10xLaCroixDrinker 7d2fac3
chore: update deps
10xLaCroixDrinker 519dac4
test(integration): update for fastify fixes
10xLaCroixDrinker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,152 @@ | ||
/* | ||
* Copyright 2024 American Express Travel Related Services Company, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
* or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
const allowedDangles = [ | ||
// one-app | ||
'__INITIAL_STATE__', | ||
'__render_mode__', | ||
// holocron | ||
'__CLIENT_HOLOCRON_MODULE_MAP__', | ||
'__HOLOCRON_EXTERNALS__', | ||
// redux | ||
'__REDUX_DEVTOOLS_EXTENSION_COMPOSE__', | ||
// prom-client | ||
'_metrics', | ||
// lean-intl | ||
'__addLocaleData', | ||
// webpack | ||
'__webpack_public_path__', | ||
]; | ||
|
||
module.exports = { | ||
root: true, | ||
extends: 'amex', | ||
plugins: ['es'], | ||
parserOptions: { | ||
babelOptions: { | ||
presets: ['@babel/preset-react'], | ||
}, | ||
}, | ||
rules: { | ||
'unicorn/prefer-node-protocol': 'error', | ||
'eslint-comments/require-description': ['error', { ignore: ['eslint-enable'] }], | ||
'no-underscore-dangle': ['error', { allow: allowedDangles }], | ||
'default-param-last': 0, | ||
}, | ||
overrides: [ | ||
{ | ||
files: ['__performance__/**'], | ||
globals: { | ||
__ENV: true, | ||
}, | ||
rules: { | ||
// These scripts are not run directly, and the k6 package is a placeholder | ||
'import/no-unresolved': ['error', { ignore: ['k6'] }], | ||
}, | ||
}, | ||
{ | ||
files: [ | ||
'**/__mocks__/**', | ||
'**/__tests__/**', | ||
], | ||
extends: 'amex/test', | ||
rules: { | ||
// a lot of tests require changing the environment the file is started in | ||
'global-require': 0, | ||
// this is a server, a lot of console spies are added | ||
'no-console': 0, | ||
'no-underscore-dangle': ['error', { allow: allowedDangles }], | ||
}, | ||
}, | ||
{ | ||
files: ['src/server/**'], | ||
rules: { | ||
// console methods are how we log events | ||
'no-console': 0, | ||
}, | ||
}, | ||
{ | ||
files: [ | ||
// Parts of the server that are only used in development | ||
'src/server/devHolocronCDN.js', | ||
'src/server/utils/devCdnFactory.js', | ||
'src/server/utils/watchLocalModules.js', | ||
'src/server/utils/logging/config/development.js', | ||
// Client service worker just needs `@americanexpress/one-service-worker` at build time | ||
'src/client/service-worker/**', | ||
], | ||
rules: { | ||
'import/no-extraneous-dependencies': ['error', { devDependencies: true }], | ||
}, | ||
}, | ||
{ | ||
files: ['src/client/service-worker/**'], | ||
rules: { | ||
// for clearer error reporting, having anonymous functions may inhibit us from | ||
// collecting a concise stack trace with the proper names of invoked functions | ||
'prefer-arrow-callback': 'off', | ||
// generally, self is acceptable to use in a service worker script | ||
// we want to allow this behavior throughout | ||
'no-restricted-globals': ['off', 'self'], | ||
}, | ||
}, | ||
{ | ||
// Allow console logs in documentation | ||
files: ['**/*.md/*.{js,javascript,jsx,node}'], | ||
rules: { | ||
'no-console': 0, | ||
}, | ||
}, | ||
{ | ||
files: ['prod-sample/**'], | ||
rules: { | ||
'import/no-unresolved': 'off', | ||
}, | ||
}, | ||
{ | ||
files: ['prod-sample/sample-modules/**'], | ||
rules: { | ||
'react/no-unknown-property': ['error', { ignore: ['css'] }], | ||
}, | ||
}, | ||
{ | ||
files: [ | ||
'scripts/**', | ||
'one-app-statics/**', | ||
], | ||
rules: { | ||
// these scripts should be used only during development | ||
'import/no-extraneous-dependencies': ['error', { devDependencies: true, optionalDependencies: true, peerDependencies: false }], | ||
// we need to message the user for DX | ||
'no-console': 'off', | ||
'global-require': 'off', | ||
'import/no-dynamic-require': 'off', | ||
}, | ||
}, | ||
{ | ||
files: ['scripts/dangers/**'], | ||
globals: { | ||
danger: 'readonly', | ||
fail: 'readonly', | ||
markdown: 'readonly', | ||
message: 'readonly', | ||
peril: 'readonly', | ||
schedule: 'readonly', | ||
warn: 'readonly', | ||
}, | ||
}, | ||
], | ||
}; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is related to updating the bundler in sample modules