Use correct call convention for AssocQueryStringW() #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kryptos-FR
added a commit
to fragcolor-xyz/shards
that referenced
this pull request
Feb 1, 2023
There is an issue at link time with symbol `AssocQueryStringW` for Windows targets. It breaks from version 0.8.4 onwards. PR amodm/webbrowser-rs#63 doesn't seem to fix it.
sinkingsugar
added a commit
to fragcolor-xyz/shards
that referenced
this pull request
Feb 2, 2023
* fix some issues in wires.cpp * bonus bump rust crates * Force use of webbrowser version 0.8.3 There is an issue at link time with symbol `AssocQueryStringW` for Windows targets. It breaks from version 0.8.4 onwards. PR amodm/webbrowser-rs#63 doesn't seem to fix it. * remove webbrowser --------- Co-authored-by: Nicolas Musset <musset.nicolas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor issue introduced by #62 that broke build on 32-bit Windows targets.