fix some issues in wires.cpp

[sinkingsugar]

No description provided.

[codecov]

Codecov Report

Merging #543 (d50ea45) into devel (f4016cf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            devel     #543      +/-   ##
==========================================
+ Coverage   81.35%   81.38%   +0.02%     
==========================================
  Files         243      243              
  Lines       30180    30183       +3     
==========================================
+ Hits        24554    24563       +9     
+ Misses       5626     5620       -6     

Impacted Files	Coverage Δ
src/core/shards/wires.cpp	85.64% <100.00%> (+0.04%)	⬆️
src/core/shards/math.hpp	91.68% <0.00%> (+0.27%)	⬆️
src/core/shards/network.cpp	93.24% <0.00%> (+2.10%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Kryptos-FR]

Did you just bump tract-onnx version ? I don't have that many changes in Cargo.lock when I do it locally.
Or did you do a full cargo update?

On that note, is it something we should automate somehow (or have a manual CI job, just like the string one)?

[sinkingsugar]

Did you just bump tract-onnx version ? I don't have that many changes in Cargo.lock when I do it locally. Or did you do a full cargo update?

On that note, is it something we should automate somehow (or have a manual CI job, just like the string one)?

deleted cargo.lock and regenerated yea

[Kryptos-FR]

There is another tool we can also consider in such case: cargo upgrade (which is part of cargo-edit). It updates Cargo.toml with latest compatible versions (based on SemVer I think).

[Kryptos-FR]

Re: build failures. It looks like it is caused by webbrowser-rs version 0.8.4+ which now uses AssocQueryStringW Windows API (cf. amodm/webbrowser-rs@ff7b51e). We should keep version 0.8.3 in Cargo.lock

To do so, we can force the version in Cargo.toml:

webbrowser = { version = "= 0.8.3", optional = true }