Conditionally set dataset per-event based on :service.name (#6)

Follow the OTEL spec and set the dataset per-event based on the :service.name property, if it's present.
amperity · Aug 14, 2023 · 4ae667e · 4ae667e
1 parent e339ee7
commit 4ae667e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,7 +8,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
-...
+### Changed
+- Conditionally set dataset per-event based on the `:service.name` property,
+  following the OTEL spec.
+  [PR#6](https://github.com/amperity/ken-honeycomb/pull/6)
 
 
 ## [1.1.0] - 2023-05-08

diff --git a/src/ken/honeycomb.clj b/src/ken/honeycomb.clj
@@ -119,10 +119,12 @@
         (.setTimestamp event (inst-ms timestamp)))
       (when-let [sample-rate (::event/sample-rate data)]
         (.setSampleRate event (long sample-rate)))
+      ;; Follow OTEL spec and set dataset based on service.name.
+      (when-let [service-name (:service.name data)]
+        (.setDataset event service-name))
       ;; TODO: it's possible for events to override some of the client
       ;; properties; how should this be exposed?
       ;; - ApiHost
-      ;; - Dataset
       ;; - Metadata
       ;; - WriteKey
       event)))