Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally set dataset per-event based on :service.name #6

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

drewinglis
Copy link
Contributor

Follow the OTEL spec and set the dataset per-event based on the :service.name property, if it's present.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Patch coverage: 6.06% and project coverage change: -9.52% ⚠️

Comparison is base (d1210dd) 44.89% compared to head (136e133) 35.38%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   44.89%   35.38%   -9.52%     
==========================================
  Files           1        1              
  Lines          98      130      +32     
  Branches        0        1       +1     
==========================================
+ Hits           44       46       +2     
- Misses         54       83      +29     
- Partials        0        1       +1     
Files Changed Coverage Δ
src/ken/honeycomb.clj 35.38% <6.06%> (-9.52%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drewinglis drewinglis merged commit 4ae667e into main Aug 14, 2023
@drewinglis drewinglis deleted the drew/set-dataset branch August 14, 2023 17:03
drewinglis added a commit that referenced this pull request Aug 14, 2023
drewinglis added a commit that referenced this pull request Aug 16, 2023
…" (#7)

This reverts commit 4ae667e.

This doesn't work properly with the batch libhoney consumer, since it sets the dataset for all events in the batch based on the dataset of the first event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants