Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config file .proselintrc isn't installed #1194

Closed
mavit opened this issue Jul 6, 2021 · 0 comments · Fixed by #1195
Closed

Config file .proselintrc isn't installed #1194

mavit opened this issue Jul 6, 2021 · 0 comments · Fixed by #1195
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: high Issues and PRs that should be resolved as soon as possible. status: wip Issues and PRs that are still a work in progress. type: build Issues and PRs related to application build steps.

Comments

@mavit
Copy link
Contributor

mavit commented Jul 6, 2021

In version 0.10.2, setup.py contains:

    package_data={'': ['demo.md', '.proselintrc']},

In version 0.11.2, this has become:

package_data = \
{'': ['*']}

The wildcard * appears not to match files starting with ., meaning that .proselintrc doesn’t get installed.
mavit added a commit to mavit/proselint that referenced this issue Jul 6, 2021
@mavit
Rename system .proselintrc to proselintrc
b6d8eb6 
Fixes amperser#1194.
@mavit mavit mentioned this issue Jul 6, 2021
Merged
@Nytelife26 Nytelife26 added cat: maintenance Issues and PRs related to the maintenance of a module. priority: high Issues and PRs that should be resolved as soon as possible. status: wip Issues and PRs that are still a work in progress. type: build Issues and PRs related to application build steps. labels Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: high Issues and PRs that should be resolved as soon as possible. status: wip Issues and PRs that are still a work in progress. type: build Issues and PRs related to application build steps.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: fix package bundling to include proselintrc and tests mavit/proselint
2 participants
@mavit @Nytelife26