Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix package bundling to include proselintrc and tests #1195

Merged
merged 1 commit into from
Jul 6, 2021
Merged

build: fix package bundling to include proselintrc and tests #1195

merged 1 commit into from
Jul 6, 2021

Conversation

mavit
Copy link
Contributor

@mavit mavit commented Jul 6, 2021 •
edited by Nytelife26
Loading

Fixes #1194. Fixes #1193.

Resolves #1196

@Nytelife26
Copy link
Member

This doesn't seem right. The package data should not solely be a wildcard, it should be exactly those three locations. I'll investigate now.

@Nytelife26 Nytelife26 added cat: maintenance Issues and PRs related to the maintenance of a module. priority: urgent Issues and PRs that must be resolved immediately. status: wip Issues and PRs that are still a work in progress. type: chore Issues and PRs related to changes that do not fit into other categories. version: patch Issues and PRs with bug fixes belonging to the next patch release. labels Jul 6, 2021
@Nytelife26 Nytelife26 added status: review-ready PRs that are ready for author review. and removed status: wip Issues and PRs that are still a work in progress. labels Jul 6, 2021
@Nytelife26 Nytelife26 changed the title Rename system .proselintrc to proselintrc fix package bundling to include proselintrc and tests Jul 6, 2021
This was referenced Jul 6, 2021
Closed
Merged
@Nytelife26 Nytelife26 added type: build Issues and PRs related to application build steps. and removed type: chore Issues and PRs related to changes that do not fit into other categories. labels Jul 6, 2021
@Nytelife26 Nytelife26 changed the title fix package bundling to include proselintrc and tests build: fix package bundling to include proselintrc and tests Jul 6, 2021
@Nytelife26 Nytelife26 merged commit 1be2032 into amperser:main Jul 6, 2021
@mavit mavit mentioned this pull request Jul 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nytelife26 Nytelife26 Awaiting requested review from Nytelife26 Nytelife26 is a code owner

@suchow suchow Awaiting requested review from suchow suchow is a code owner

Assignees
No one assigned
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: urgent Issues and PRs that must be resolved immediately. status: review-ready PRs that are ready for author review. type: build Issues and PRs related to application build steps. version: patch Issues and PRs with bug fixes belonging to the next patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config file .proselintrc isn't installed Tests missing from pypi.org
2 participants
@mavit @Nytelife26