Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: switch pycodestyle -> flake8 #1198

Merged
merged 3 commits into from
Jul 6, 2021
Merged

style: switch pycodestyle -> flake8 #1198

merged 3 commits into from
Jul 6, 2021

Conversation

Nytelife26
Copy link
Member

@Nytelife26 Nytelife26 commented Jul 6, 2021

This relates to...

CI failure on #1195 and our linting system.

Rationale

pycodestyle is very out of date, and doesn't catch everything.
Furthermore, it is prone to errors and cannot read our
pyproject.toml file. flake8 is a modern alternative, also
produced by the Python Code Quality Authority.

Changes

  • switch pycodestyle -> flake8 in ci
  • update run_ci_checks.sh
  • apply new linting
  • finalize port to py3

Features

N/A.

Bug Fixes

N/A.

Breaking Changes and Deprecations

N/A.

@Nytelife26 Nytelife26 requested a review from suchow as a code owner July 6, 2021 21:05
@Nytelife26 Nytelife26 added cat: maintenance Issues and PRs related to the maintenance of a module. priority: high Issues and PRs that should be resolved as soon as possible. status: review-ready PRs that are ready for author review. type: ci Issues and PRs related to continuous integration. labels Jul 6, 2021
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #1198 (ecf06d6) into main (0816a5b) will decrease coverage by 0.38%.
The diff coverage is 98.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1198      +/-   ##
==========================================
- Coverage   94.72%   94.34%   -0.39%     
==========================================
  Files          83       82       -1     
  Lines        1213     1131      -82     
==========================================
- Hits         1149     1067      -82     
  Misses         64       64              
Flag Coverage Δ
macos-latest 94.34% <98.94%> (-0.39%) ⬇️
py3.6 93.74% <98.94%> (-0.47%) ⬇️
py3.7 93.74% <98.94%> (-0.47%) ⬇️
py3.8 94.34% <98.94%> (-0.39%) ⬇️
py3.9 94.34% <98.94%> (-0.39%) ⬇️
pypypy3 93.74% <98.94%> (-0.47%) ⬇️
ubuntu-latest 94.34% <98.94%> (-0.39%) ⬇️
windows-latest 94.34% <98.94%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
proselint/checks/consistency/spacing.py 100.00% <ø> (ø)
proselint/checks/consistency/spelling.py 100.00% <ø> (ø)
proselint/checks/hedging/misc.py 100.00% <ø> (ø)
proselint/checks/lgbtq/terms.py 100.00% <ø> (ø)
proselint/checks/misc/back_formations.py 100.00% <ø> (ø)
proselint/checks/misc/capitalization.py 100.00% <ø> (ø)
proselint/checks/misc/commercialese.py 100.00% <ø> (ø)
proselint/checks/misc/inferior_superior.py 100.00% <ø> (ø)
proselint/checks/misc/institution_name.py 100.00% <ø> (ø)
proselint/checks/misc/latin.py 100.00% <ø> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0816a5b...ecf06d6. Read the comment docs.

@Nytelife26 Nytelife26 changed the title switch pycodestyle -> flake8 style: switch pycodestyle -> flake8 Jul 6, 2021
@Nytelife26 Nytelife26 merged commit 8e0f740 into main Jul 6, 2021
@Nytelife26 Nytelife26 deleted the ci/flake8 branch July 6, 2021 21:22
@Nytelife26 Nytelife26 added type: style Issues and PRs related to stylistic code choices. and removed type: ci Issues and PRs related to continuous integration. labels Jul 6, 2021
@Nytelife26 Nytelife26 restored the ci/flake8 branch August 22, 2021 20:58
@Nytelife26 Nytelife26 deleted the ci/flake8 branch August 22, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: high Issues and PRs that should be resolved as soon as possible. status: review-ready PRs that are ready for author review. type: style Issues and PRs related to stylistic code choices.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant