Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS syntax error in tag 'style amp-custom' - bad url. #604

Closed
k-atul opened this issue Jan 9, 2017 · 4 comments
Closed

CSS syntax error in tag 'style amp-custom' - bad url. #604

k-atul opened this issue Jan 9, 2017 · 4 comments
Labels
Support Help with setup, implementation, or "How do I?" questions.

Comments

@k-atul
Copy link

k-atul commented Jan 9, 2017 •
edited
Loading

Plugin is not creating background url for inline amp-wp styling for Instagram embed, the inline style code is breaking due to no image url, please add a fallback or fix for the same. Broken style "background:url(", we are on wordpress VIP.

Please check below url:
http://indianexpress.com/article/entertainment/bollywood/jennifer-lopez-nicole-scherzinger-add-star-power-to-sanjay-hinduja-anu-mahtanis-udaipur-wedding/lite/
http://indianexpress.com/article/lifestyle/fashion/lily-cole-flaunts-dress-made-of-plastic-bottles-on-the-oscars-2016-red-carpet/lite/

.amp-wp-inline-6b058bf4d14bfd6100311e6b5d86d8fe{background:url(data:image/png;display:block;height:44px;margin:0 auto -44px;position:relative;top:-22px;max-width:44px;}
delputnam added a commit to delputnam/amp-wp that referenced this issue Jan 16, 2017
@delputnam
Changes to address issue ampproject#604. Replaced with which uses AMP…
d5c1f80 
…_Allowed_Styles_Generated to validate CSS. Also replaced use of with a custom function which ignores delimiters in parentheses and quotation marks.
@delputnam delputnam mentioned this issue Jan 16, 2017
Closed
delputnam added a commit to delputnam/amp-wp that referenced this issue Jan 29, 2017
@delputnam
Merge pull request #2 from delputnam/fix/amp-style-sanitizer
84ee0af 
Changes to address issue ampproject#604. Replaced  with  which uses AMP_Allowed…
@maxhartshorn
Copy link

Any updates here? Our amp-validation is breaking because of this issue

@trepmal trepmal mentioned this issue Mar 25, 2017
Merged
@amedina
Copy link
Member

amedina commented Jul 6, 2017

The links provided validate successfully; are you still experiencing this issue?

@k-atul
Copy link
Author

k-atul commented Jul 6, 2017

@amedina its fixed. thanks

@amedina
Copy link
Member

amedina commented Jul 6, 2017

Thanks @k-atul; glad to hear. Thanks for using the plugin reporting the issue.

@amedina amedina closed this as completed Jul 6, 2017
@jonhendershot jonhendershot mentioned this issue Apr 20, 2018
Closed
@swissspidy swissspidy added the Support Help with setup, implementation, or "How do I?" questions. label Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Support Help with setup, implementation, or "How do I?" questions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@amedina @swissspidy @maxhartshorn @k-atul