Replace explode with preg_split. #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @trepmal. I'm working on fixing the (unrelated broken) tests but it would be good to add some tests for this particular fix and an inline comment with details on what the regex is trying to catch. |
|
Writing a test against core is proving tricky since At the moment, it's impossible to bypass However, there are some tickets hoping to fix/modernize/filter https://core.trac.wordpress.org/ticket/24157 |
In cases where Jetpack's `safecss_filter_attr` is used in place of core's function (and possibly other scenarios), there may be semi-colons in unexpected places. For example, `background-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAA...);` In that case, `explode` will break the style, splitting it in the middle of a value. With `preg_split` we can specify semi-colons that are not inside parentheses.
mjangda
force-pushed
the
fix/process_style
branch
from
c1593e6
to
37e4b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where Jetpack's
safecss_filter_attris used in place of core's function (and possibly other scenarios), there may be semi-colons in unexpected places.For example,
background-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAA...);In that case,
explodewill break the style, splitting it in the middle of a value. Withpreg_splitwe can specify semi-colons that are not inside parentheses.