fix get-involved-banner text color #1768
Conversation
| @@ -155,5 +155,5 @@ <h2 class="ap-o-video-slider-text">Featured Videos</h2> | |||
| {% do doc.styles.addCssFile('/css/components/organisms/banner.css') %} | |||
| <section class="ap--banner"> | |||
| <h2 class="ap-o-banner-headline">Get Involved</h2> | |||
| <p class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</p> | |||
| <span class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</span> | |||
There was a problem hiding this comment.
Why did you switch to span here? From a markup perspective, p seems to be a better fit.
There was a problem hiding this comment.
The css inside our template targets all p tags and is overwriting the stylings for ap-o-banner. It was my thought that a simple fix for this bug without adding additional css would be to change the tag type, however I agree that keeping the p tag is preferable. I'll work Robin to find an alternative
There was a problem hiding this comment.
Cool, can we get the fix in the next 1 hour?
There was a problem hiding this comment.
@sebastianbenz yes the fix should be on it's way shortly
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
No description provided.