Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get-involved-banner text color #1768

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/scss/base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ html, body {
padding: 0;
margin: 0;
min-width: 320px;
color: color('black');
color: color('river-bed');
background-color: #fff;
font-size: 16px;
font-family: sans-serif;
Expand Down
9 changes: 4 additions & 5 deletions frontend/scss/components/organisms/banner.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,17 @@

.#{utility('banner')} {
margin: 0 -30px;
padding: 30px 30px;
padding: 60px 30px;
background-color: color('blue-ribbon');

@media (min-width: 930px) {
padding: 70px 90px 70px 90px;
padding: 90px;
}
}

.#{organism('banner')} {

&-headline, &-copy {
color: color('white');
&-headline, p {
max-width: 720px;
color: color('white');
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ <h2 class="ap-o-video-slider-text">Featured Videos</h2>

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}
<section class="ap--banner">
<h2 class="ap-o-banner-headline">Get Involved</h2>
<p class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</p>
<div class="ap-o-banner">
<h2 class="ap-o-banner-headline">Get Involved</h2>
<p class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</p>
</div>
</section>
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ <h2 class="ap-o-video-slider-text">Featured Videos</h2>

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}
<section class="ap--banner">
<h2 class="ap-o-banner-headline">Get Involved</h2>
<p class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</p>
<div class="ap-o-banner">
<h2 class="ap-o-banner-headline">Get Involved</h2>
<p class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</p>
</div>
</section>
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ <h2 class="ap-o-video-slider-text">Featured Videos</h2>

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}
<section class="ap--banner">
<h2 class="ap-o-banner-headline">Get Involved</h2>
<p class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</p>
<div class="ap-o-banner">
<h2 class="ap-o-banner-headline">Get Involved</h2>
<p class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</p>
</div>
</section>
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ <h2 class="ap-o-video-slider-text">Featured Videos</h2>

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}
<section class="ap--banner">
<h2 class="ap-o-banner-headline">Get Involved</h2>
<p class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</p>
<div class="ap-o-banner">
<h2 class="ap-o-banner-headline">Get Involved</h2>
<p class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</p>
</div>
</section>
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,8 @@ <h2 class="ap-o-video-slider-text">Featured Videos</h2>

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}
<section class="ap--banner">
<h2 class="ap-o-banner-headline">Get Involved</h2>
<p class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</p>
<div class="ap-o-banner">
<h2 class="ap-o-banner-headline">Get Involved</h2>
<p class="ap-o-banner-copy">AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.</p>
</div>
</section>