-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗🐛 Fix gulp test --coverage
#16417
🏗🐛 Fix gulp test --coverage
#16417
Conversation
Works but the uncovered line numbers it reports don't map to the actual src.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, understanding that line numbers issues will be a later PR
@jpettitt The discrepancy between line numbers and the actual source appears to be due to gotwarlost/istanbul#59. The fix involves some trial and error, so I'll work on a fix in a separate PR. |
Re: #16417 (comment), the line number discrepancy is addressed in #16432. With the fix in place, here's what you'll see for |
Our code coverage tools have been broken for a while. This PR fixes them, such that
gulp test [--unit|--local-changes|--files] --coverage
prints a neatly formatted text code coverage report and pops up a rich HTML report in your default browser.gulp test --local-changes
with--coverage
(coming up in a separate PR).Fixes #16396