Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗🐛 Fix source mapping in code coverage report #16432

Merged
merged 1 commit into from
Jun 28, 2018
Merged

🏗🐛 Fix source mapping in code coverage report #16432

merged 1 commit into from
Jun 28, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jun 28, 2018

This PR makes it so that when you run gulp test --coverage, the source code properly lines up with the coverage annotations in the HTML report.

With this fix in place, here's what you'll see for amp-geo.js, for example:

image

Addresses #16417 (comment)
Follow up to #16417
Fixes #16396

@rsimha rsimha self-assigned this Jun 28, 2018
@rsimha rsimha requested a review from jpettitt June 28, 2018 05:41
@rsimha
Copy link
Contributor Author

rsimha commented Jun 28, 2018

/to @jpettitt

Copy link
Contributor

@jpettitt jpettitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsimha rsimha merged commit 62262e8 into ampproject:master Jun 28, 2018
@rsimha rsimha deleted the 2018-06-28-CoverageFix branch June 28, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gulp test --coverage --files ... throws errors
3 participants