-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[amp-story-player] Introduce render() method ♻️ #32153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
force-pushed
the
player-refactor-1
branch
from
January 25, 2021 17:16
f66b085
to
e93d399
Compare
Enriqe
changed the title
[amp-story-player] Introduce render() method
[amp-story-player] Introduce render() method ♻️
Jan 25, 2021
gmajoulet
reviewed
Jan 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic ❤️
We discussed the review offline but for transparency:
- remove addingStories and look at if the current StoryDef has a connected iframe instead. That makes it a bit more automatic and easy to use it's cool.
- Remove the
limit
, I think with the early return in the loop we don't really need this kind of optimization, especially if it makes the code a bit easier - Move the early return a bit higher so we don't even create a render promise
…wait on changing story before changing page
Enriqe
force-pushed
the
player-refactor-1
branch
from
January 29, 2021 23:46
cded821
to
6166bc1
Compare
gmajoulet
approved these changes
Feb 1, 2021
This was referenced Feb 3, 2021
This was referenced Aug 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
render()
method which consolidates a lot of the logic from different methods, effectively reducing the amount codepaths.Follow up for #32115
Closes #31212
Closes #31010
Closes #31445
Closes #31562
Closes #31925
Closes #31738