Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp-story-player] Introduce render() method ♻️ #32153

Merged
merged 9 commits into from
Feb 1, 2021
Merged

[amp-story-player] Introduce render() method ♻️ #32153

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7088ff9
introduce main render method
Enriqe Jan 25, 2021
11f7cd3
dont block on visiblityState change
Enriqe Jan 25, 2021
2bd706d
add sync property for storyContentLoaded, extract logic from setSrc, …
Enriqe Jan 25, 2021
ee8b93b
add tests for new show() functionality
Enriqe Jan 25, 2021
f82b3bd
renames
Enriqe Jan 25, 2021
4ade272
reduce args in render(), fix names, fix errors logs
Enriqe Jan 29, 2021
6166bc1
fix test
Enriqe Jan 29, 2021
21e1ea2
merge conflict
Enriqe Jan 29, 2021
249d389
update e2e test
Enriqe Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading