Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe storybook #577

Merged
merged 1 commit into from
Aug 13, 2020
Merged

docs: describe storybook #577

merged 1 commit into from
Aug 13, 2020

Conversation

dorianj
Copy link
Contributor

@dorianj dorianj commented Aug 13, 2020

Signed-off-by: Dorian Johnson 2020@dorianj.net

Summary of Changes

Include a summary of changes then remove this line

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

@dorianj dorianj mentioned this pull request Aug 13, 2020
5 tasks
docs/developer_guide.md Outdated Show resolved Hide resolved
Signed-off-by: Dorian Johnson <2020@dorianj.net>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Golodhros Golodhros merged commit cfe6e91 into amundsen-io:master Aug 13, 2020
@dorianj dorianj deleted the dj-storybook-doc branch August 13, 2020 17:35
allisonsuarez pushed a commit that referenced this pull request Aug 18, 2020
Signed-off-by: Dorian Johnson <2020@dorianj.net>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
jerryzhu2007 pushed a commit to kylg/amundsenfrontendlibrary that referenced this pull request Aug 20, 2020
* commit 'd2f222ea5cb648fb4a9d9bd2e242a3b36281098d': (63 commits)
  feat: Update 'table view', 'alumni' and SLA status badges (amundsen-io#595)
  build: Adding betterer to workflow (amundsen-io#598)
  build(deps): bump flask-restful from 0.3.7 to 0.3.8 (amundsen-io#553)
  chore: Removes 84 unused variables (amundsen-io#600)
  chore: remove travis badge and update doc link (amundsen-io#599)
  Fixes error on TableDetail on Dev (amundsen-io#597)
  chore: Bump version for pypi release. (amundsen-io#596)
  feat: Announcements in Homepage (amundsen-io#591)
  build(deps-dev): bump @babel/plugin-proposal-logical-assignment-operators (amundsen-io#574)
  build(deps): [security] bump lodash in /amundsen_application/static (amundsen-io#587)
  build(deps-dev): bump @babel/plugin-proposal-export-namespace-from (amundsen-io#588)
  build(deps-dev): bump lint-staged in /amundsen_application/static (amundsen-io#590)
  chore: fix docker push action (amundsen-io#593)
  feat: add github actions for FE (amundsen-io#592)
  chore: Re-useable OwnerEditor (amundsen-io#548)
  feat: Show more tags in browse and home  (amundsen-io#532)
  Organizes, themes and adds typography stories (amundsen-io#578)
  docs: describe storybook (amundsen-io#577)
  Fixes TypeScript issues with sagas and saga tests (amundsen-io#573)
  build(deps-dev): bump @babel/core in /amundsen_application/static (amundsen-io#558)
  ...

# Conflicts:
#	amundsen_application/api/utils/metadata_utils.py
#	amundsen_application/oidc_config.py
#	amundsen_application/static/js/components/TableDetail/ColumnList/index.tsx
#	amundsen_application/static/js/components/TableDetail/ColumnListItem/index.tsx
#	amundsen_application/static/js/components/TableDetail/constants.ts
#	amundsen_application/static/js/components/TableDetail/index.tsx
#	amundsen_application/static/js/config/index.spec.ts
#	amundsen_application/static/js/ducks/tableMetadata/reducer.ts
#	amundsen_application/static/js/fixtures/globalState.ts
#	amundsen_application/static/js/fixtures/metadata/table.ts
#	amundsen_application/static/js/interfaces/TableMetadata.ts
#	docs/application_config.md
#	requirements.txt
#	setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants