fix: Fixes error on TableDetail on Dev #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Golodhros
requested review from
dikshathakur3119 and
ttannis
and removed request for
dikshathakur3119
ttannis
approved these changes
Aug 19, 2020
jerryzhu2007
pushed a commit
to kylg/amundsenfrontendlibrary
that referenced
this pull request
Aug 20, 2020
* commit 'd2f222ea5cb648fb4a9d9bd2e242a3b36281098d': (63 commits) feat: Update 'table view', 'alumni' and SLA status badges (amundsen-io#595) build: Adding betterer to workflow (amundsen-io#598) build(deps): bump flask-restful from 0.3.7 to 0.3.8 (amundsen-io#553) chore: Removes 84 unused variables (amundsen-io#600) chore: remove travis badge and update doc link (amundsen-io#599) Fixes error on TableDetail on Dev (amundsen-io#597) chore: Bump version for pypi release. (amundsen-io#596) feat: Announcements in Homepage (amundsen-io#591) build(deps-dev): bump @babel/plugin-proposal-logical-assignment-operators (amundsen-io#574) build(deps): [security] bump lodash in /amundsen_application/static (amundsen-io#587) build(deps-dev): bump @babel/plugin-proposal-export-namespace-from (amundsen-io#588) build(deps-dev): bump lint-staged in /amundsen_application/static (amundsen-io#590) chore: fix docker push action (amundsen-io#593) feat: add github actions for FE (amundsen-io#592) chore: Re-useable OwnerEditor (amundsen-io#548) feat: Show more tags in browse and home (amundsen-io#532) Organizes, themes and adds typography stories (amundsen-io#578) docs: describe storybook (amundsen-io#577) Fixes TypeScript issues with sagas and saga tests (amundsen-io#573) build(deps-dev): bump @babel/core in /amundsen_application/static (amundsen-io#558) ... # Conflicts: # amundsen_application/api/utils/metadata_utils.py # amundsen_application/oidc_config.py # amundsen_application/static/js/components/TableDetail/ColumnList/index.tsx # amundsen_application/static/js/components/TableDetail/ColumnListItem/index.tsx # amundsen_application/static/js/components/TableDetail/constants.ts # amundsen_application/static/js/components/TableDetail/index.tsx # amundsen_application/static/js/config/index.spec.ts # amundsen_application/static/js/ducks/tableMetadata/reducer.ts # amundsen_application/static/js/fixtures/globalState.ts # amundsen_application/static/js/fixtures/metadata/table.ts # amundsen_application/static/js/interfaces/TableMetadata.ts # docs/application_config.md # requirements.txt # setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcos Iglesias miglesiasvalle@lyft.com
Summary of Changes
Fixes error on table
Cleans unused text
CheckList
Make sure you have checked all steps below to ensure a timely review.