feat: Alerts component #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golodhros
requested review from
allisonsuarez,
dikshathakur3119 and
ttannis
as code owners
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
ttannis
previously approved these changes
Aug 28, 2020
|
|
||
| const AlertIcon: React.FC = () => { | ||
| return ( | ||
| <svg |
There was a problem hiding this comment.
Would it make sense to have a common/icons where we start putting new amundsen icons that use inline-svgs?
There was a problem hiding this comment.
Makes sense! I will move it there!
| <AlertIcon /> | ||
| <p className="alert-message">{message}</p> | ||
| {actionText && onAction && ( | ||
| <button type="button" className="btn btn-link" onClick={onAction}> |
There was a problem hiding this comment.
For our internal use case, the text will end up being a link to another Amundsen page. Given our desire to use the correct components for specific actions, do you think we should still support a button with onClick vs and anchor with an href...or both?
There was a problem hiding this comment.
Oh, I see.
I could make it support both easily. I will add an optional actionHref prop, if that has a value, I will render a router Link instead
Golodhros
force-pushed
the
mi-alerts
branch
2 times, most recently
from
98cc40e to
93da3e4
Compare
Supporting an action link Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
… Alert Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
ttannis
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds the alerts component
Includes tests and a SVG icon for the alert
Documentation
Added Storybook story for the component
CheckList
Make sure you have checked all steps below to ensure a timely review.