-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kernel critical extension bypass #501
Conversation
147fd36
to
e863ee3
Compare
@wagoodman : I can't seem to "request review by reviewers".... Are you guys actually maintaining this as an open-source thingy, accepting PRs? Is there a chance of my change ending on the mainline? I ask because: Either way is ok, I'd obviously prefer to not rely on my fork, if I don't have to, but not a big deal...... |
@tecimovic this LGTM I think the only thing we need left here is is sign off for the DCO check:
If you get that fixed I can then get this 🟢 and merged |
e863ee3
to
f20f043
Compare
@spiffcs Thank you! I did all that now, I think it's now just complaining about the "approving review". |
Nice - looks like this is just blocked on #500 -- I'll see if I can ask @wagoodman today, but he's got a lot going on right now. If I have some spare cycles I can also look at the PR that fixes these fixtures |
Thank you, much appreciated! Also a lot of thanks to having this project in the first place! The whole thing of "You need a Mac to sign things for a Mac" was terribly annoying in my world for many years..... I'll be happy to pick this up as soon as it merges, and my urgency is NOT on the "TODAY!" scale. No problem waiting for few days... Nobody needs to loose sleep today over it! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I confirmed the additional oid from http://www.apple.com/certificateauthority/Apple_Developer_ID_CPS/
Signed-off-by: Timotej Ecimovic <t1@digitalgeyser.com> Signed-off-by: Timotej Ecimovic <timotej.ecimovic@silabs.com>
f20f043
to
b2fd214
Compare
forced pushed a rebase since the test fixtures have been fixed 🎉 |
The certificate files I got from Apple for my project also contain another critical extension: "devid_kernel".
I added a bypass for it, same way as there was previously there a bypass for "devid_execute".