Deprecate config.yaml as valid config source; Add unit regression for correct config paths #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only add the pwd to the config search path if and only if it contains a config file that we expect. This avoids incorrectly finding config files that may be specific to applictions other than syft. fixes: anchore#1634 Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
|
👋 Thanks for the PR @AidanDelaney - do you mind if I make a quick update the keeps the current behavior, but adds a warning. We're looking to release syft v1.0.0 in the future and think this is a good candidate for that handover. I don't want to merge this PR as is and break setups for people who are relying on discovering Instead, if we introduce your changes, but still allow I'll also make sure to add your issue to our v1 milestone so we don't miss removing the warning and sunsetting the wrong behavior |
|
Please feel free to make any update you'd like. I think that adding |
|
Yep! We'll keep it open - I added it to our milestone tracking for v1.0.0 - I'll push the warning change now and merge this keeping the old behavior, but with the notice of deprecation and intent to fix by v1.0.0 |
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
spiffcs
changed the title
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
kzantow
approved these changes
Mar 20, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
kzantow
reviewed
Mar 20, 2023
kzantow
reviewed
Mar 20, 2023
wagoodman
reviewed
Mar 20, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
spiffcs
changed the title
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
|
Big thanks to @AidanDelaney for surfacing this issue - it's on the board for v1.0.0 |
spiffcs
added a commit
to deitch/syft
that referenced
this pull request
Mar 21, 2023
* main: (47 commits) Deprecate config.yaml as valid config source; Add unit regression for correct config paths (anchore#1640) chore: Update syft bootstrap tools to latest versions. (anchore#1682) Update documentation: (anchore#1680) chore: Update Stereoscope to 7928713c391e20abaede6a029f4ce37b628a4c8b (anchore#1681) fix: reduce logging for bad dpkg lines (anchore#1675) fix ruby classifier (anchore#1678) feat: add shared dir for easier cleanup (anchore#1676) chore(deps): bump github.com/google/go-containerregistry (anchore#1672) chore(deps): bump actions/setup-go from 3 to 4 (anchore#1671) fix: move defer after error to protect panic case (anchore#1670) feat: add argocd, helm, kustomize and kubectl binary classifiers (anchore#1663) defer closing file (anchore#1668) fix: remove author contributing to javascript CPEs (anchore#1669) fix: more python matching support (anchore#1667) Update syft bootstrap tools to latest versions. (anchore#1666) feat: add ruby classifier (anchore#1665) Update syft bootstrap tools to latest versions. (anchore#1658) fix: improved Python binary detection (anchore#1648) fix: suppress some known incorrect vendor candidates for npm CPEs (anchore#1659) fix: sanitize SPDX LicenseRefs (anchore#1657) ... Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
This was referenced Mar 31, 2023
Closed
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
… correct config paths (anchore#1640) Warn user of future deprecation of ./config.yaml for v1.0.0 release --------- Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net> Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> Co-authored-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add the pwd to the config search path if and only if it contains a config file that we expect. This avoids incorrectly finding config files that may be specific to applictions other than syft.
partially addresses #1634